Differentiate objects and object properties #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love this one! But maybe the purple font is a bit too dark with that background? |
|
Possibly. It looks OK to me, but again - I'm colorblind - so I'm not the best judge. Happy to change it if you have an alternate suggestion! Just needs to stand out from adjacent text. |
|
Looks great to me! |
|
Hey there! Sorry for the delay on reviewing this. Looks great, I plan on merging it into master this weekend. |
|
Still interested in this? 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
I noticed objects were pretty visually homogeneous and coming from other themes that target variables and properties separately from parent objects, etc. I felt they should be easier to digest at a glance. I tried to replicate that here. I chose one color that you already use and another from FluoroMachine, but feel free to adjust them as needed if you have any interest in this change. I used some pretty general scopes and made up names for the rules - feel free to change them or propose others of course. Lastly, I didn't add glow anywhere, not sure if that's needed or not.
Result
Before:
After:
Disclaimer
I don't know anything about making themes, and I'm colorblind, so take this PR with a grain of salt. 🙂
Thanks for reviewing.